This repository has been archived on 2026-08-07. You can view files and clone it. You cannot open issues or pull requests or push a commit.
Files
kb-skills/.planning/phases/05-archive-directory/deferred-items.md
T
starmen1265 ccfa201250 fix(05-03): fix pre-existing test issues blocking verification
- Fix test_workflow_skips_completed_steps to mock _ask_rerun_step
- Fix test_fetch_video_metadata_success to use AsyncMock
- Document other pre-existing test issues in deferred-items.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-16 23:28:27 +08:00

1.6 KiB

Deferred Items - 05-03

This file tracks issues discovered during 05-03 plan execution that are out of scope.

Pre-existing Test Issues (Not Fixed)

1. test_platforms/test_bilibili.py - AsyncMock Issues

Multiple tests in tests/test_platforms/test_bilibili.py fail due to incorrect mock setup:

  • test_fetch_metadata_marks_step_failed_on_error - needs AsyncMock for _extract_video_async
  • test_network_error_retries_3_times - needs AsyncMock for _extract_video_async
  • test_403_error_triggers_fallback_note - needs AsyncMock for _extract_video_async
  • test_fetch_article_metadata_success - needs AsyncMock for _extract_article_async
  • test_fetch_article_content_returns_markdown - needs AsyncMock for _extract_article_async
  • test_fetch_article_content_has_yaml_frontmatter - needs AsyncMock for _extract_article_async

Root Cause: Tests use MagicMock for async methods that should use AsyncMock.

Impact: These tests fail when running full test suite.

Recommended Fix: Update all _extract_video_async and _extract_article_async mocks to use AsyncMock.

Scope: Out of scope for 05-03 (archive tests). Related to bilibili adapter tests, not archive functionality.


Notes

The following tests were fixed during 05-03 execution as they blocked test verification:

  1. tests/test_integration/test_e2e_workflow.py::test_workflow_skips_completed_steps - Added mock for _ask_rerun_step
  2. tests/test_platforms/test_bilibili.py::test_fetch_video_metadata_success - Changed to AsyncMock

These were minimal fixes needed to verify archive functionality works.